-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs for equality and DataFrames #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
#### Equality | ||
|
||
Two `AbstractInterval`s are considered equal if they have identical left and right | ||
endpoints (taking `Inclusivity` into account): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be really great to have docstrings for LeftEndpoint
and RightEndpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Perhaps the person who wrote those could be convinced to document them... 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, that guy is a slacker ;). I'll open an issue for this as I don't think I'll have the time at the moment: #28
|
||
julia> join(df2, df3; on=:time) | ||
0×3 DataFrames.DataFrame | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra whitespace? I guess this is actually what is produced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct! It looked weird when I removed it, so I left it in.
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 183 183
=====================================
Hits 183 183 Continue to review full report at Codecov.
|
Adds documentation detailing some special considerations to be made when comparing
Interval
s withAnchoredInterval
s.